-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to enable http/2 ? #17
Comments
We do not currently have an option for this in place, so that's a feature request. |
HTTP/2 needs an SSL connection and docksal/web doesn't use that protocol. So I'd assume it would be enough to have the proxy use ssl + http/2. |
I did some googling, but did not find a solid answer on the downsides of terminating HTTP/2 at the proxy level. Based on my understanding, the end user gets 2 out of 3 key benefits of HTTP/2 when it's terminated at the proxy level:
Server push would only be possible if the proxy caches responses from the origin OR if it talks to the origin over HTTP/2 and proxies pushes (not 100% positive on this one). In fact, Nginx doesn't even support server push with HTTP/2 yet (1, 2) UPDATE: Server Push support was added in Nginx v1.13.9 (released February 20, 2018) I think terminating HTTP/2 a the proxy level should be fine, especially since we are already terminating TLS there. Resources: |
Sounds great! Thanks for this very good/detailed answer! So would it be enough to include a boolean configuration flag that set the http2-flag in the nginx-configuration of the proxy? |
Any news on this subject? |
@JensvdHeydt no, sorry. This has not been a priority. Feel free to submit a PR, to get the ball rolling :) |
This is now available in the edge image version: To try this out, reset vhost-proxy like this:
or (if using the latest
|
Server Push support was added in Nginx v1.13.9 (released February 20, 2018) |
Is there an option or could you maybe add an environment variable to enable http/2 for SSL connections?
The text was updated successfully, but these errors were encountered: