PHP 8.0 #221

sean-e-dietrich · 2021-04-17T07:18:14Z

Imagick installed from source: New release with PHP 8 support? Imagick/imagick#358
Pantheon Terminus is broken (not compatible with PHP 8.0: PHP8 Support pantheon-systems/terminus#2113)
Dropped drush registry_rebuild extension (resolves Drop drush registry_rebuild extension #224)
Dropped cgr (composer global require alternative) (resolves Drop cgr (composer global require replacement) #225)
Dropped drush backdrop extension (resolves Drop drush backdrop extension #223)
Dropped mg2-codegen (resolves Drop mg2-codegen (Magento 2 Code Generator) #222)
Updated README

Resolves #202

.github/workflows/default.yaml

lmakarov · 2021-04-22T05:28:36Z

After cleaning up a few legacy or rarely used tools, this one is the last standing issue: pantheon-systems/terminus#2113

Otherwise yaml rounds something like 8.0 to 8 as a number vs a string.

lmakarov · 2021-05-14T22:35:55Z

Disabled terminus and Pantheon integration tests for the time being. terminus is still included in cli but in a broken state.
Anyone looking to use terminus in docksal/cli:php8.0 is welcome to chime in the upstream issue.

sean-e-dietrich requested a review from lmakarov April 17, 2021 07:18

sean-e-dietrich linked an issue Apr 17, 2021 that may be closed by this pull request

Add PHP 8.0.0 support #202

Closed

sean-e-dietrich commented Apr 17, 2021

View reviewed changes

.github/workflows/default.yaml Show resolved Hide resolved

lmakarov force-pushed the feature/php80 branch from a07521c to 63258a0 Compare April 21, 2021 22:02

sean-e-dietrich and others added 15 commits May 14, 2021 11:38

Initial build of php 8.0

c878cbd

Updated README

6757779

Updated deployment

a3523c2

Updated docker to add back in backdrop

5dd5241

Updated workflow

8355f5a

Updated workflow

9bf508e

Wrap version numbers in quotes

d9d9563

Otherwise yaml rounds something like 8.0 to 8 as a number vs a string.

Fix test pass/failure check in Github Actions config

75b5fb6

Dropped mg2-codegen (#222)

78af92f

Sync config and dependency versions in PHP 8.0 image

7e38737

Dropped drush backdrop extension (#223)

de30e2a

Dropped drush registry_rebuild extension (#224)

b02cee1

Dropped cgr (composer global require alternative) (#225)

95175dc

Skip terminus check in tests for PHP 8.0

d33824d

Rebased onto develop and synced settings.

1baae5d

lmakarov force-pushed the feature/php80 branch from 27c8486 to 1baae5d Compare May 14, 2021 18:39

Skip terminus and Pantheon tests for PHP 8.0

d4c4ac3

lmakarov force-pushed the feature/php80 branch from 13ae153 to d4c4ac3 Compare May 14, 2021 21:28

lmakarov self-assigned this May 14, 2021

lmakarov added the enhancement label May 14, 2021

lmakarov approved these changes May 14, 2021

View reviewed changes

lmakarov merged commit 95b23f6 into develop May 14, 2021

lmakarov deleted the feature/php80 branch May 14, 2021 22:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP 8.0 #221

PHP 8.0 #221

sean-e-dietrich commented Apr 17, 2021 •

edited by lmakarov

Loading

lmakarov commented Apr 22, 2021

lmakarov commented May 14, 2021

PHP 8.0 #221

PHP 8.0 #221

Conversation

sean-e-dietrich commented Apr 17, 2021 • edited by lmakarov Loading

lmakarov commented Apr 22, 2021

lmakarov commented May 14, 2021

sean-e-dietrich commented Apr 17, 2021 •

edited by lmakarov

Loading