Add config input #67
Merged
Add config input #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMartinez-Sisti
force-pushed
the
config-input
branch
from
fabe901 to
8a6cc21
Compare
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 78.18% 78.18%
=======================================
Files 5 5
Lines 110 110
Branches 19 19
=======================================
Hits 86 86
Misses 18 18
Partials 6 6
Continue to review full report at Codecov.
|
|
Had to force push due to missing DCO. |
crazy-max
requested changes
Apr 22, 2021
|
@GMartinez-Sisti LGTM minus a small change in action.yml. About test I will do that through the ci workflow in a further PR. Will let you know. |
Signed-off-by: Gabriel Martinez <gabrielmartinez@sisti.pt>
GMartinez-Sisti
force-pushed
the
config-input
branch
from
8a6cc21 to
9b36596
Compare
Right, I missed that one! Done. I force pushed to keep it clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
Hi, as discussed on #66, this PR adds a new input named
config. The input accepts a string that is the path for the buildkitd daemon configuration file.This is my first contribution on typescript but, if I understood the flow correctly, this change should be enough to make it work. @crazy-max please let me know how we can add a test to this.
Thanks!