tag-latest: true not working

[felipecrs]

Please see this build as example:

https://github.com/felipecrs/jenkins-agent-dind/runs/1812044006

Despite docker-meta receives "tag-latest: true" as input, the only tags generated are "master".

Also reported it #40 apparently.

[crazy-max]

@felipecrs https://github.com/crazy-max/ghaction-docker-meta#latest-tag

[felipecrs]

Got it. The docs says the tag-latest can be disabled if needed, but not deliberately enabled. Is that right?

Any tip on how I can achieve the same behavior as the Docker Hub Automated Build, pushing master branch to latest?

[felipecrs]

I believe the tag-latest input should be respected if provided by the user no matter what. To implement that, its default value must not be true anymore, then we treat the undefined cases.

This is very similar to an old PR I made to the legacy docker action: docker/github-actions#20

[crazy-max]

@felipecrs I think you could specify a custom tag as latest in this case with tag-custom input. Or maybe we could handle 3 states for tag-latest: auto|true|false.

[felipecrs]

@crazy-max Awesome. May I send a PR?

[beevelop]

I experienced the same issue and am actually trying to build the master branch as latest. If you have a dedicated repository for the Docker builds, you can work around this limitation by renaming the master branch to latest 🎩

[felipecrs]

As an alternative workaround you can do what I did at felipecrs/docker-images@1900c95.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.