Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct misplaced calls to Get/List in Watch/WatchTree for etcd #27

Merged
merged 1 commit into from
Jul 20, 2015

Conversation

abronan
Copy link
Contributor

@abronan abronan commented Jul 20, 2015

Calls to Get and List in Watch and WatchTree are misplaced for etcd which causes the watch to not work properly with libnetwork and swarm for the Leader Election recovery on etcd

See #26

Signed-off-by: Alexandre Beslic abronan@docker.com

Signed-off-by: Alexandre Beslic <abronan@docker.com>
@vieux
Copy link
Contributor

vieux commented Jul 20, 2015

LGTM

abronan added a commit that referenced this pull request Jul 20, 2015
Correct misplaced calls to Get/List in Watch/WatchTree for etcd
@abronan abronan merged commit 15aa29c into docker:master Jul 20, 2015
@vieux vieux deleted the etcd_watch_fix branch July 20, 2015 20:37
thegrumpylion pushed a commit to thegrumpylion/libkv that referenced this pull request Apr 3, 2020
The maintenance of the boltdb project moved to a
fork: github.com/coreos/bbolt. While the original
boltdb repository is itself at a stable state, we
switch to this active fork for the improved reliability
and stability goals.

Fixes docker#27

Signed-off-by: Alexandre Beslic <abeslic@abronan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants