-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update run-tests.md #16710
Update run-tests.md #16710
Conversation
The tests literally didn't work for me. I'm not sure what breaking changes appear to have come in since they were first written, but a major problem was that calling `.WithNetwork()` passing in a not-yet-started network would throw an exception. Most of the changes are around coping with that - moving code from ctor to the `InitializeAsync()` method.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thank you, @nbarnwell. Your changes fix the exception for me. Hi @HofmeisterAn, PTAL if you can. |
I believe the appropriate solution is to set the version to 2.3.0 by using the command Additionally, we are in the process of implementing module support, which will make the documentation and usage much more straightforward in the future. As part of my responsibilities, I will be updating the Docker documentation once the new version is released. It should only be necessary to update this line: docs/language/dotnet/run-tests.md Line 29 in 8275c6f
Should I create a PR? |
I mean, fair enough. But you are opening yourself up to having to revisit this page one day because folks will come here looking for how to use the latest version, only to find the docs stuck at v2.3. I guess choose your pain. :) |
With the next release, the API will be stable. Unfortunately, despite taking great care to avoid introducing breaking changes, I was not completely successful.
It is in my own interest to ensure that the Docker documentation is up-to-date. With new TC releases, I am happy to update the documentation as well. |
The tests literally didn't work for me. I'm not sure what breaking changes appear to have come in since they were first written, but a major problem was that calling
.WithNetwork()
passing in a not-yet-started network would throw an exception. Most of the changes are around coping with that - moving code from ctor to theInitializeAsync()
method.Proposed changes
Related issues (optional)