Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: fix incorrectly named libnetwork label #12921

Merged
merged 1 commit into from
May 31, 2021

Conversation

thaJeztah
Copy link
Member

The correct name is com.docker.network.container_iface_prefix, but
the changelog accidentally used interface instead of iface, because
the libnetwork pull request used that as a title.

relates to docker/cli#2984
relates to moby/moby#31811
relates to moby/libnetwork#1667
relates to moby/moby#42446

The correct name is `com.docker.network.container_iface_prefix`, but
the changelog accidentally used `interface` instead of `iface`, because
the libnetwork pull request used that as a title.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added the area/engine Issue affects Docker engine/daemon label May 31, 2021
@thaJeztah
Copy link
Member Author

@StefanScherer ptal

@netlify
Copy link

netlify bot commented May 31, 2021

✔️ Deploy Preview for docsdocker ready!

🔨 Explore the source changes: 3d143df

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/60b4e5493cf4fd0007589e07

😎 Browse the preview: https://deploy-preview-12921--docsdocker.netlify.app

Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@thaJeztah thaJeztah merged commit d4fc9b6 into docker:master May 31, 2021
@thaJeztah thaJeztah deleted the fix_changelog_entry branch May 31, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issue affects Docker engine/daemon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants