Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for systemd drop-ins #1103

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

thaJeztah
Copy link
Member

When creating a /etc/systemd/system/docker.service unit file, that file replaces the default (/lib/systemd/system/docker.service) unit file.

While this may be intended by some, this section describes how to use "partial" unit files ("drop-ins") to override only certain properties of the default unit file.

This patch removes the mention of /etc/systemd/system/docker.service to prevent users from inadvertently replacing the default unit file.

Relates to moby/moby#30063 (comment). Thanks @ijrandom for bringing this to our attention 👍

ping @mstanleyjones PTAL

When creating a `/etc/systemd/system/docker.service`
unit file, that file _replaces_ the default
(`/lib/systemd/system/docker.service`) unit file.

While this may be intended by some, this section
describes how to use "partial" unit files ("drop-ins")
to override only certain properties of the default
unit file.

This patch removes the mention of
`/etc/systemd/system/docker.service` to prevent
users from inadvertently replacing the default
unit file.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdlinville mdlinville merged commit 611206f into docker:master Jan 18, 2017
@thaJeztah thaJeztah deleted the fix-systemd-instructions branch January 18, 2017 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants