-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows credential helper doesn't support passwords greater than 2,500 characters in length #190
Comments
It looks like there are similar problems with Azure SSO: aws/aws-cli#5636 (comment) |
Curious is this new @dougrday ? |
@Anthropic I don't have any issues with the old version, but I guess you also saw that yourself. It only happens when using permissions generated through SSO, and only if docker uses Windows Credential Manager |
I haven't tried myself, but my teammates have reported that the 2.3.x versions don't exhibit this problem. As a temporary workaround, I've created this credential helper that stored the SSO credentials in plaintext in Windows. Our SSO tokens are only valid for a few hours, so the window of risk of plaintext goes down, but I still consider this a workaround, not a solution. If anyone needs a stop-gap to keep working, here it is: https://github.com/dougrday/docker-credential-plaintext |
I got around it by deleting |
Thank you very much for providing this temporary workaround. I have my code inside WSL, and found that I also had to add the file extension in
Note that this is the config file inside WSL. I took me a little too long to understand why docker complained about not finding it in the |
This still occurs! Confirmed removing credStore entry fixes with sso |
I tried all the solution mentioned here. Nothing worked for me. Tried this workaround as below
It worked. Posting it here if anyone finds it useful |
This worked perfectly for me. Thanks! |
These tests are failing on Windows because the native executable backing them is failing (docker-credential-wincred.exe). When running these tests, we get an error saying "The stub received bad data." (which appears to be the Win32 error message for RPC_X_BAD_STUB_DATA). Ref: docker/docker-credential-helpers#190 Signed-off-by: Mark Yen <mark.yen@suse.com>
These tests are failing on Windows because the native executable backing them is failing (docker-credential-wincred.exe). When running these tests, we get an error saying "The stub received bad data." (which appears to be the Win32 error message for RPC_X_BAD_STUB_DATA). Ref: docker/docker-credential-helpers#190 Signed-off-by: Mark Yen <mark.yen@suse.com>
These tests are failing on Windows because the native executable backing them is failing (docker-credential-wincred.exe). When running these tests, we get an error saying "The stub received bad data." (which appears to be the Win32 error message for RPC_X_BAD_STUB_DATA). Ref: docker/docker-credential-helpers#190 Signed-off-by: Mark Yen <mark.yen@suse.com>
Worked for me, thanks
|
This is still a problem and the workaround can't be used in Github Actions on Windows runners. |
When authenticating Docker with AWS, the recommend practice from AWS is this:
aws ecr get-login-password | docker login --username AWS --password-stdin <registry>
When AWS SSO is enabled, the value returned from
get-login-password
is greater than 2,500 characters in length, which causes the credential helper to fail. I've tested with both thedesktop
helper andwincred
helper, both of which fail with this message:Error saving credentials: error storing credentials - err: exit status 1, out: 'The stub received bad data.'
This is a fairly blocking issue for Windows developers, as they cannot log into the Docker registry if the authentication secret is large enough.
The text was updated successfully, but these errors were encountered: