-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static: add containerd-shim-runc-v2 #465
Conversation
That probably doesn't work yet, until moby/moby#40882 is merged (which is why I opened it 😅 ) Interestingly; CI is green, but the copy failed 🤔
|
moby/moby#40882 got merged |
containerd-shim-runc-v2 is used in cgroup v2 mode Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
feaa7d1
to
9120150
Compare
@thaJeztah @silvin-lubecki PTAL? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AkihiroSuda @thaJeztah I am trying to use containerd 1.3.7 from the static package of Docker 19.03.13 and getting this:
Should this be cherrypicked to the 19.03 branch? |
@hakman yes, to get it in the static package, that would be needed. Docker 19.03 itself does not use the v2 shim, so didn't need it. In case it helps; the |
Could be, but not necessarily, because Docker does not use |
If you don't mind, I can create the cherry-pick. We use the static packages in Kops because it's pretty much the only way to get some official ARM64 builds for containerd. |
containerd-shim-runc-v2 is used in cgroup v2 mode