Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static: add containerd-shim-runc-v2 #465

Merged
merged 1 commit into from
May 13, 2020

Conversation

AkihiroSuda
Copy link
Contributor

containerd-shim-runc-v2 is used in cgroup v2 mode

@thaJeztah
Copy link
Member

That probably doesn't work yet, until moby/moby#40882 is merged (which is why I opened it 😅 )

Interestingly; CI is green, but the copy failed 🤔


make[2]: Leaving directory '/home/ubuntu/workspace/docker-ce-packaging_PR-465/engine'
mkdir -p build/linux/docker
cp /home/ubuntu/workspace/docker-ce-packaging_PR-465/cli/build/docker build/linux/docker/
for f in dockerd containerd ctr containerd-shim containerd-shim-runc-v2 docker-init docker-proxy runc; do \
	cp -L /home/ubuntu/workspace/docker-ce-packaging_PR-465/engine/bundles/binary-daemon/$f build/linux/docker/$f; \
done
cp: cannot stat '/home/ubuntu/workspace/docker-ce-packaging_PR-465/engine/bundles/binary-daemon/containerd-shim-runc-v2': No such file or directory

@AkihiroSuda
Copy link
Contributor Author

moby/moby#40882 got merged

containerd-shim-runc-v2 is used in cgroup v2 mode

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda force-pushed the containerd-shim-runc-v2 branch from feaa7d1 to 9120150 Compare May 7, 2020 23:56
@AkihiroSuda
Copy link
Contributor Author

@thaJeztah @silvin-lubecki PTAL?

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit fcbe366 into docker:master May 13, 2020
@hakman
Copy link

hakman commented Oct 9, 2020

@AkihiroSuda @thaJeztah I am trying to use containerd 1.3.7 from the static package of Docker 19.03.13 and getting this:

ctr: runtime "io.containerd.runc.v2" binary not installed "containerd-shim-runc-v2": file does not exist: unknown

Should this be cherrypicked to the 19.03 branch?

@thaJeztah
Copy link
Member

@hakman yes, to get it in the static package, that would be needed. Docker 19.03 itself does not use the v2 shim, so didn't need it.

In case it helps; the .deb and .rpm containerd.io packages on download.docker.com should have the shim included

@AkihiroSuda
Copy link
Contributor Author

Should this be cherrypicked to the 19.03 branch?

Could be, but not necessarily, because Docker does not use ctr

@hakman
Copy link

hakman commented Oct 9, 2020

If you don't mind, I can create the cherry-pick. We use the static packages in Kops because it's pretty much the only way to get some official ARM64 builds for containerd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants