Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TAR-352] Add initial basis for cli-plugins (docker/app) #309

Merged
merged 3 commits into from
Mar 8, 2019
Merged

[TAR-352] Add initial basis for cli-plugins (docker/app) #309

merged 3 commits into from
Mar 8, 2019

Conversation

seemethere
Copy link
Contributor

@seemethere seemethere commented Mar 5, 2019 •
edited
Loading

Adds the base functionality for providing cli-plugins in our packaging.

Adding a plugin

Adding a plugin is pretty straightforward:

  1. Create a bash script in the root directory plugins with the extension .installer
  2. Have the .installer script implement a build and install_plugin function (those are pretty self explanatory)
  3. Have the .installer script source "$(dirname "$0")/.common at the beginning of the script
  4. Have the .installer script call build_or_install at the end of its script

Dependencies

@seemethere
Add initial rigging for cli-plugin building
85c375b 
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere seemethere requested a review from a team March 5, 2019 22:44
@seemethere
Add plugin installation for DEB and RPM
b7a0a8f 
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere seemethere changed the title Add initial basis for cli-plugins WIP Add initial basis for cli-plugins Mar 6, 2019
@seemethere seemethere changed the title WIP Add initial basis for cli-plugins WIP [TAR-352] Add initial basis for cli-plugins Mar 6, 2019
@seemethere seemethere changed the title WIP [TAR-352] Add initial basis for cli-plugins WIP [TAR-352] Add initial basis for cli-plugins (docker/app) Mar 6, 2019
@seemethere seemethere removed the request for review from a team March 6, 2019 00:08
@seemethere seemethere requested a review from a team March 8, 2019 19:14
@seemethere seemethere changed the title WIP [TAR-352] Add initial basis for cli-plugins (docker/app) [TAR-352] Add initial basis for cli-plugins (docker/app) Mar 8, 2019
dave-tucker
dave-tucker previously approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemethere
Add initial script for docker/app cli-plugin
43bf924 
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
duhruh
duhruh approved these changes Mar 8, 2019
View reviewed changes
Copy link

@duhruh duhruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOKS GREAT 😺

StefanScherer
StefanScherer approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemethere seemethere merged commit bc1e358 into docker:master Mar 8, 2019
@seemethere seemethere deleted the add_ploogins branch March 8, 2019 19:30
@teohhanhui teohhanhui mentioned this pull request Nov 25, 2019
Closed
@HeroCC HeroCC mentioned this pull request Jan 14, 2020
Closed
@tianon tianon mentioned this pull request May 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duhruh duhruh duhruh approved these changes

@russellcardullo russellcardullo russellcardullo approved these changes

@StefanScherer StefanScherer StefanScherer approved these changes

@dave-tucker dave-tucker dave-tucker left review comments

@silvin-lubecki silvin-lubecki Awaiting requested review from silvin-lubecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seemethere @StefanScherer @russellcardullo @duhruh @dave-tucker