Prefixes documentation files per component #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
andrewhsu
suggested changes
Jun 19, 2017
rpm/centos-7/docker-ce.spec
Outdated
| for engine_file in engine/AUTHORS engine/CHANGELOG.md engine/CONTRIBUTING.md engine/LICENSE engine/MAINTAINERS engine/NOTICE engine/README.md; do | ||
| cp "$engine_file" "build-docs/engine-$(basename $engine_file)" | ||
| done | ||
| for cli_file in cli/LICENSE cli/MAINTAINERS cli/NOTICE cli/README.md; do |
There was a problem hiding this comment.
No need to depend on basename:
for cli_file in LICENSE MAINTAINERS NOTICE README.md; do
cp "cli/$cli_file" "build-docs/cli-$cli_file"
done
There was a problem hiding this comment.
Fixed per 8251d8f
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
6 tasks
andrewhsu
approved these changes
Jun 20, 2017
glours
pushed a commit
that referenced
this pull request
Mar 23, 2020
* Prefixes documentation files per component Signed-off-by: Eli Uriegas <eli.uriegas@docker.com> * Remove reliance on basename Signed-off-by: Eli Uriegas <eli.uriegas@docker.com> (cherry picked from commit 24e443c) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we pull from multiple components to build docker-ce now it makes sense to have all of the related files associated with each component packaged into RPMS.
This will prefix all files that were previously included in the RPM with the component from which they originate.
End result will look like so: