Update docker-compose run --rm doc #5997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "patch-1" git@github.com:orenyomtov/compose.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842361863064
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
To make the functionality added in https://github.com/funkyfuture/docker-compose/commit/24ab933ebfd3169491beeb18f0041cabebe4d2d2 explicit in the docs Signed-off-by: Oren Yomtov <thenameisoren@gmail.com>
To make the functionality added in https://github.com/funkyfuture/docker-compose/commit/24ab933ebfd3169491beeb18f0041cabebe4d2d2 explicit in the docs
|
Thanks for the PR! As I explained in docker/docs#6803 (comment), I don't think it's the right approach for this to appear in the CLI's output. I'm closing this as a result, but I'm looking forward to adding this to our docs all the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
docker-compose run --rmdoc to explicitly state the change made here:https://github.com/funkyfuture/docker-compose/commit/24ab933ebfd3169491beeb18f0041cabebe4d2d2
Following this issue:
#1013
I had to use Google to and follow the discussion in #1013 in order to know how to properly achieve what I wanted, after not finding the answer in
docker-compose run --help.Resolves #1013