fix(dockerignore): Add wildcard support to dockerignore.go #12239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
glours
approved these changes
Oct 28, 2024
| @@ -0,0 +1,92 @@ | |||
| package watch | |||
There was a problem hiding this comment.
You need to add the license header to this new file
There was a problem hiding this comment.
thank you, pushed fix
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added wildcard support to
dockerignore::NewDockerPatternMatcher, because if the .dockerignore contains a wildcard to ignore all files + lines with an exclusion, it ignores all files while it shouldn't ignore the excluded filesRelated issue
#12236
PR to reproduce the bug #12238
(not mandatory) A picture of a cute animal, if possible in relation to what you did
