Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert gpus to DeviceRequests with implicit "gpu" capability #12197

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Oct 9, 2024

What I did

This adds support for gpus to align with docker CLI
Coucou Guillaume 🥰

Related issue
compose-spec/compose-go#693

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 9eeb2d3 into docker:main Oct 9, 2024
28 checks passed
@ndeloof ndeloof deleted the gpus branch October 9, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants