Does not start menu manager if there is no tty on up #11672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Handle when there is no tty available and navigation menu is enabled. Also gracefully handle key events when an error occurs instead of panic.
Also did small refactor in
cmd/up.go
related withNavigationMenu
validation.This can be tested locally by running:
make sure you have
util-linux
installRelated issue
fixes https://docker.atlassian.net/browse/DDB-25
(not mandatory) A picture of a cute animal, if possible in relation to what you did