Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dry-run support for publish command #11067

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

glours
Copy link
Contributor

@glours glours commented Oct 5, 2023

What I did
Add --dry-run support to alpha publish command to avoid pushing artifacts to the registry

Related issue
Issue reported by a Docker Captain during DockerCon

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours requested review from ndeloof and milas October 5, 2023 18:35
@glours glours self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (a345515) 57.55% compared to head (dc49396) 57.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11067      +/-   ##
==========================================
- Coverage   57.55%   57.48%   -0.07%     
==========================================
  Files         129      129              
  Lines       11237    11239       +2     
==========================================
- Hits         6467     6461       -6     
- Misses       4141     4147       +6     
- Partials      629      631       +2     
Files Coverage Δ
pkg/compose/publish.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof merged commit 2c0b023 into docker:main Oct 5, 2023
@jkoenig134
Copy link

Hehe, that captain was me messing around with the new publish feature. Great that you found the error!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants