don't apply "rebuild" watch strategy by default #10710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10710 +/- ##
==========================================
+ Coverage 58.90% 58.96% +0.05%
==========================================
Files 112 112
Lines 9743 9735 -8
==========================================
+ Hits 5739 5740 +1
+ Misses 3417 3409 -8
+ Partials 587 586 -1
☔ View full report in Codecov by Sentry. |
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
stop automatically creating a "rebuild" watch config for services without an explicit develop section
Related issue
fixes #10626
fixes #10570
https://docker.atlassian.net/browse/ENV-213
(not mandatory) A picture of a cute animal, if possible in relation to what you did