Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary [] output #10554

Merged
merged 2 commits into from
May 11, 2023
Merged

fix: remove unnecessary [] output #10554

merged 2 commits into from
May 11, 2023

Conversation

ezradiniz
Copy link
Contributor

Fixes #10550

Signed-off-by: Mateus Esdras <linux.esdras@gmail.com>
pkg/compose/remove.go Outdated Show resolved Hide resolved
pkg/compose/remove.go Outdated Show resolved Hide resolved
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: +40.21 🎉

Comparison is base (0e375a8) 19.40% compared to head (9ff355f) 59.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##               v2   #10554       +/-   ##
===========================================
+ Coverage   19.40%   59.62%   +40.21%     
===========================================
  Files         104      107        +3     
  Lines        9228     9328      +100     
===========================================
+ Hits         1791     5562     +3771     
+ Misses       7250     3193     -4057     
- Partials      187      573      +386     
Impacted Files Coverage Δ
pkg/compose/kill.go 56.09% <0.00%> (-1.41%) ⬇️
pkg/compose/push.go 0.00% <0.00%> (ø)
pkg/compose/watch.go 25.10% <20.00%> (+0.85%) ⬆️
pkg/compose/compose.go 65.43% <40.00%> (+25.95%) ⬆️
pkg/compose/pause.go 43.47% <50.00%> (+43.47%) ⬆️
pkg/compose/build.go 73.05% <100.00%> (+69.17%) ⬆️
pkg/compose/cp.go 60.60% <100.00%> (+60.60%) ⬆️
pkg/compose/create.go 61.41% <100.00%> (+47.02%) ⬆️
pkg/compose/down.go 69.12% <100.00%> (+2.76%) ⬆️
pkg/compose/image_pruner.go 79.83% <100.00%> (+3.68%) ⬆️
... and 6 more

... and 66 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@milas milas merged commit 77dc9b5 into docker:v2 May 11, 2023
@ezradiniz ezradiniz deleted the 10550-fix branch May 12, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Removing containers when none are running results in output artifact []
3 participants