Update 🥒 tests to use dockerfile_inline
#10508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurazard
requested review from
a team,
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
milas
and removed request for
a team
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10508 +/- ##
==========================================
+ Coverage 19.35% 19.37% +0.02%
==========================================
Files 104 104
Lines 9197 9197
==========================================
+ Hits 1780 1782 +2
+ Misses 7230 7228 -2
Partials 187 187 ☔ View full report in Codecov by Sentry. |
|
LGTM. Maybe we could have both ? |
ndeloof
approved these changes
Apr 28, 2023
glours
approved these changes
Apr 28, 2023
|
Yup! I changed both since the previous usecase is already thoroughly covered in the other tests, but we can add another cucumber scenario to make sure both are covered here. I'll TAL at it later. |
milas
approved these changes
May 8, 2023
milas
suggested changes
May 8, 2023
laurazard
force-pushed
the
tests-inline-dockerfile
branch
2 times, most recently
from
617ea30
to
514d154
Compare
laurazard
force-pushed
the
tests-inline-dockerfile
branch
from
514d154
to
2fb448b
Compare
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
laurazard
force-pushed
the
tests-inline-dockerfile
branch
from
2fb448b
to
ee70085
Compare
milas
approved these changes
May 9, 2023
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Update Cucumber tests to use
dockerfile_inlinewhen appropriate, for clarity (and coverage).(not mandatory) A picture of a cute animal, if possible in relation to what you did