add dry-run support to run command #10404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
requested review from
a team,
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
milas and
laurazard
and removed request for
a team
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10404 +/- ##
===========================================
- Coverage 60.13% 18.85% -41.28%
===========================================
Files 104 101 -3
Lines 9005 8919 -86
===========================================
- Hits 5415 1682 -3733
- Misses 3023 7050 +4027
+ Partials 567 187 -380
... and 79 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ndeloof
reviewed
Mar 26, 2023
There was a problem hiding this comment.
I'm not sure to understand what you try to do here in ContainerCreate. Return existing container as a successful create if one existed ? But then this is not what would happen if user removes --dry-run flag as we will then create a second container for service
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
dry-run-run-support
branch
from
f55f576
to
72a61c0
Compare
ndeloof
approved these changes
Mar 27, 2023
milas
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add dry-run support for the
runcommandRelated issue
https://docker.atlassian.net/browse/ENV-66
(not mandatory) A picture of a cute animal, if possible in relation to what you did
