Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade to Go 1.20.2 & bump deps #10401

Merged
merged 3 commits into from
Mar 24, 2023
Merged

ci: upgrade to Go 1.20.2 & bump deps #10401

merged 3 commits into from
Mar 24, 2023

Conversation

milas
Copy link
Contributor

@milas milas commented Mar 24, 2023

What I did
Update all the things!

  • Go 1.20.2
  • golangci-lint v1.52.0
  • compose-go v1.13.1

(not mandatory) A picture of a cute animal, if possible in relation to what you did
quokka

* Go 1.20.2
* golangci-lint v1.52.0
* compose-go v1.13.1: https://github.com/compose-spec/compose-go/releases/tag/v1.13.1

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas added the dependencies Pull requests that update a dependency file label Mar 24, 2023
@milas milas requested a review from a team March 24, 2023 13:46
@milas milas self-assigned this Mar 24, 2023
@milas milas requested review from nicksieger, ndeloof, StefanScherer, ulyssessouza, glours and laurazard and removed request for a team March 24, 2023 13:46
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -41.31 ⚠️

Comparison is base (72260d6) 60.16% compared to head (45a852f) 18.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##               v2   #10401       +/-   ##
===========================================
- Coverage   60.16%   18.85%   -41.31%     
===========================================
  Files         104      101        -3     
  Lines        9005     8908       -97     
===========================================
- Hits         5418     1680     -3738     
- Misses       3021     7041     +4020     
+ Partials      566      187      -379     

see 80 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Validation got improved in `compose-go` so the error message is
slightly different.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas merged commit d818bf6 into docker:v2 Mar 24, 2023
@milas milas deleted the deps-update branch March 24, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants