introduce ignore attribute for watch triggers
#10385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10385 +/- ##
==========================================
- Coverage 53.37% 53.24% -0.13%
==========================================
Files 104 104
Lines 8974 8960 -14
==========================================
- Hits 4790 4771 -19
- Misses 3664 3668 +4
- Partials 520 521 +1
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ndeloof
force-pushed
the
watch_ignores
branch
2 times, most recently
from
5f7685f
to
6cfe2de
Compare
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
StefanScherer
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
LGTM
Tested with the compose-watch-samples reactjs example, with and addition in the compose.yaml file.
services:
myapp:
build: .
ports:
- '2170:3000'
x-develop:
watch:
- path: package.json
action: rebuild
- path: package-lock.json
action: rebuild
- path: src/
action: sync
target: /app/src
ignore:
- new.swp
- node_modules/
glours
approved these changes
Mar 21, 2023
ndeloof
force-pushed
the
watch_ignores
branch
2 times, most recently
from
a2ce4c5
to
0bfd3f8
Compare
ndeloof
force-pushed
the
watch_ignores
branch
3 times, most recently
from
00e9d28
to
18e3c15
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Introduced ability to exclude some files from
syncwhen runningcompose watch.(not mandatory) A picture of a cute animal, if possible in relation to what you did