introduce restart for depends_on
#10284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
force-pushed
the
depends_on_restart
branch
from
ef70f19
to
91490cf
Compare
Codecov ReportBase: 72.79% // Head: 73.89% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10284 +/- ##
==========================================
+ Coverage 72.79% 73.89% +1.10%
==========================================
Files 2 2
Lines 272 272
==========================================
+ Hits 198 201 +3
+ Misses 62 60 -2
+ Partials 12 11 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
force-pushed
the
depends_on_restart
branch
3 times, most recently
from
93e1330
to
ce9245b
Compare
ndeloof
requested review from
a team,
nicksieger,
StefanScherer,
ulyssessouza,
glours,
milas and
laurazard
and removed request for
a team
ndeloof
force-pushed
the
depends_on_restart
branch
2 times, most recently
from
9835821
to
55b7c3b
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
depends_on_restart
branch
from
55b7c3b
to
5933763
Compare
laurazard
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce support for
restartondepends_on.this allows to declare dependent service which, when restarted, need to also trigger configured service to be restarted. Typically applies to containers sharing namespaces.
updated compose-go to v1.11 where
Normalizemakes all dependencies explicit, we can filter dependencies and ignore those which are not impacted by dependencies to be restarted.Also add support for repeated
--env-fileflag, as supported by compose-go v1.11