Fix Cucumber 🥒 tests #10124
Merged
Fix Cucumber 🥒 tests #10124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 73.89% // Head: 74.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10124 +/- ##
==========================================
+ Coverage 73.89% 74.26% +0.36%
==========================================
Files 2 2
Lines 272 272
==========================================
+ Hits 201 202 +1
+ Misses 60 59 -1
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
laurazard
requested review from
a team,
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
milas
and removed request for
a team
ndeloof
reviewed
Dec 30, 2022
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
laurazard
force-pushed
the
fix-cucumber-tests
branch
from
dd8bf9f
to
dde7eea
Compare
ndeloof
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laura Brehm laurabrehm@hey.com
What I did
Update Cucumber tests expected
compose psoutput to match new changes.(fixing these so I can make a follow up PR to add a GHA for 🥒 tests)
Run them with
go test -v ./e2eRelated issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did