Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonstream: Display: rename var that shadowed type #5787

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

thaJeztah
Copy link
Member

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added status/2-code-review kind/refactor PR's that refactor, or clean-up code labels Feb 3, 2025
@thaJeztah thaJeztah added this to the 28.0.0 milestone Feb 3, 2025
@thaJeztah thaJeztah requested a review from Benehiko February 3, 2025 15:18
@thaJeztah thaJeztah self-assigned this Feb 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.42%. Comparing base (4771aba) to head (8169a51).
Report is 2 commits behind head on master.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5787   +/-   ##
=======================================
  Coverage   59.42%   59.42%           
=======================================
  Files         347      347           
  Lines       29395    29395           
=======================================
  Hits        17469    17469           
  Misses      10954    10954           
  Partials      972      972           

@thaJeztah
Copy link
Member Author

Flaky test?

63.89 === FAIL: cli/command/image TestPrunePromptTermination (0.00s)
63.89     prune_test.go:128: assertion failed: error is "image prune has been cancelled" (errdefs.errCancelled), not "prompt terminated" (command.ErrPromptTerminated errdefs.errCancelled)

@thaJeztah thaJeztah merged commit ac13f50 into docker:master Feb 3, 2025
101 checks passed
@thaJeztah thaJeztah deleted the jsonstream_noshadow branch February 3, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants