Skip inspect of built-in networks on stack deploy

[alexmavr]

- What I did

The current flow of docker stack deploy -c performs a network inspect operation for every external network. However, built-in networks are always known to exist so these inspect calls are redundant. This PR removes them.

- How I did it
For every external network in a compose file, omit the network inspect operation if it's a built-in network ("none", "default", "container", "bridge" or "host")

- How to verify it

• Use the provided unit test

or

• Build a docker API server that returns a 404 for the "host" and "bridge" networks (such as https://github.com/docker/swarm) and run the following compose file:

version: '3.2'
services:
  api:
    image: nginx
    networks:
      host : null
networks:
  host:
    external: true

Then, verify the deployed task is attached to the "host" network on the target node.

- Description for the changelog

• Stack deploy for compose files no longer inspects built-in networks

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Alex Mavrogiannis alex.mavrogiannis@docker.com

[alexmavr]

cc @mavenugo

[mavenugo]

LGTM

Not sure why the CI is failing though...

[codecov-io]

Codecov Report

Merging #362 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   45.47%   45.49%   +0.01%     
==========================================
  Files         193      193              
  Lines       16061    16065       +4     
==========================================
+ Hits         7304     7308       +4     
  Misses       8379     8379              
  Partials      378      378

[alexmavr]

Amended my commit with no code diff - looks like CI just needed a little nudge

[thaJeztah]

LGTM

[dnephin]

I'm not really a fan of this storing state in the testcase struct.

I think the same thing can be accomplished by setting inspectError, and asserting there was no error, right?

Fixed in #365

[thaJeztah]

This didn't make the cut for 17.07, opened docker-archive/docker-ce#177 to back port it