Clear go.mod after vendor scripts ran #3536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benja-M-1
force-pushed
the
feature/clear-go-mod
branch
2 times, most recently
from
e0eda86 to
5148288
Compare
Codecov Report
@@ Coverage Diff @@
## master #3536 +/- ##
=======================================
Coverage 58.99% 59.00%
=======================================
Files 282 284 +2
Lines 23813 23816 +3
=======================================
+ Hits 14049 14053 +4
Misses 8908 8908
+ Partials 856 855 -1 |
benja-M-1
force-pushed
the
feature/clear-go-mod
branch
from
5148288 to
2ba210f
Compare
…d or outdated vendors listed. This helps to avoid `go build` to fail because of unconsistencies between go.mod and vendor/modules.txt files. Signed-off-by: Benjamin Grandfond <benjamin.grandfond@docker.com>
benja-M-1
force-pushed
the
feature/clear-go-mod
branch
4 times, most recently
from
89c12d9 to
a00f352
Compare
Signed-off-by: Benjamin Grandfond <benjamin.grandfond@docker.com>
benja-M-1
force-pushed
the
feature/clear-go-mod
branch
from
a00f352 to
bda03ef
Compare
|
@thaJeztah I finally followed up on this WIP PR. Somehow the |
thaJeztah
reviewed
May 2, 2022
Comment on lines
+80
to
+88
| while getopts ":c" opt; do | ||
| case $opt in | ||
| c) | ||
| clean | ||
| ;; | ||
| *) | ||
| ;; | ||
| esac | ||
| done |
There was a problem hiding this comment.
Perhaps we should reverse the option; by default, remove the go.mod, and only if it's needed after it ran, pass an option to --keep (or whatever) the file.
Looking at the changes, I think all (but one) calls of this script expect the go.mod to be deleted afterwards; WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This PR adds an option to remove the go.mod stub when executing a
./script/vendorcommand. It avoidsgo buildto fail because of unconsistencies between go.mod and vendor/modules.txt files.This PR also
./scripts/vendorto display the usage command when no command is passedcleancommand called after yaml and man docs have been generated- How I did it
When the following commands are ran
go buildfails with the message- How to verify it
- Description for the changelog
Clean up
go.modfile after vendors have been updated, validated or list outdated.- A picture of a cute animal (not mandatory but encouraged)