Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: align with engine at b6684a403c99aaf6be5b8ce0bef3c6650fcdcd12 #2110

Merged
merged 3 commits into from
Oct 7, 2019

Conversation

tiborvass
Copy link
Collaborator

@tiborvass tiborvass commented Sep 26, 2019

Testdata in cli/command/system/testdata needed "OSVersion":"" to be added.

vendor.conf Show resolved Hide resolved
Signed-off-by: Tibor Vass <tibor@docker.com>
@tiborvass
Copy link
Collaborator Author

@thaJeztah updated!

@thaJeztah
Copy link
Member

thaJeztah commented Oct 2, 2019

argh, sorry, meant go-winio and grpc each in their own commit 😅😔🤗

Tibor Vass added 2 commits October 2, 2019 17:47
Signed-off-by: Tibor Vass <tibor@docker.com>
Signed-off-by: Tibor Vass <tibor@docker.com>
@tiborvass
Copy link
Collaborator Author

@thaJeztah updated! I didn't see the "s" of commits in bumps to separate commits

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah
Copy link
Member

@silvin-lubecki @kolyshkin PTAL

@crosbymichael
Copy link
Contributor

LGTM

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants