-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: TestSigProxyWithTTY increase timeout #1991
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exec.CombinedOutput should not be used here because: - it redirects cmd Stdout and Stderr and we want it to be the tty - it calls cmd.Run which we already did Also, make sure we don't leave a zombie running, by calling Wait() Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
increase_timeout
branch
from
July 29, 2019 22:35
930986f
to
19a53d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1991 +/- ##
=======================================
Coverage 56.79% 56.79%
=======================================
Files 311 311
Lines 21836 21836
=======================================
Hits 12402 12402
Misses 8519 8519
Partials 915 915 |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
For some reason it fails to create the container; https://jenkins.dockerproject.org/job/docker/job/cli/job/PR-1991/3/execution/node/27/log/
|
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This should be fixed by #2016 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing now all of a sudden;#1990 (comment) #1841 (comment)
Testing if it's just slowness in Jenkins