Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: TestSigProxyWithTTY increase timeout #1991

Closed
wants to merge 5 commits into from

Conversation

thaJeztah
Copy link
Member

This test started failing now all of a sudden;#1990 (comment) #1841 (comment)

Testing if it's just slowness in Jenkins

10:06:29 === FAIL: e2e/container TestSigProxyWithTTY (6.52s)
10:06:29     proxy_signal_test.go:38: terminating PID 3438
10:06:29     proxy_signal_test.go:42: timeout hit after 5s: expected status exited != running

kolyshkin and others added 2 commits July 29, 2019 14:57
exec.CombinedOutput should not be used here because:
 - it redirects cmd Stdout and Stderr and we want it to be the tty
 - it calls cmd.Run which we already did

Also, make sure we don't leave a zombie running, by calling Wait()

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link

codecov-io commented Jul 29, 2019

Codecov Report

Merging #1991 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1991   +/-   ##
=======================================
  Coverage   56.79%   56.79%           
=======================================
  Files         311      311           
  Lines       21836    21836           
=======================================
  Hits        12402    12402           
  Misses       8519     8519           
  Partials      915      915

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

For some reason it fails to create the container; https://jenkins.dockerproject.org/job/docker/job/cli/job/PR-1991/3/execution/node/27/log/

22:56:34 === Failed
22:56:34 === FAIL: e2e/container TestSigProxyWithTTY (10.07s)
22:56:34     proxy_signal_test.go:57: exit status 1
22:56:34     proxy_signal_test.go:59: Error: No such object: repro-28872
22:56:34         
22:56:34     proxy_signal_test.go:60: 
22:56:34         
22:56:34     proxy_signal_test.go:57: exit status 1
22:56:34     proxy_signal_test.go:59: Error: No such object: repro-28872
22:56:34         
22:56:34     proxy_signal_test.go:60: 
22:56:34         
22:56:34     proxy_signal_test.go:57: exit status 1
22:56:34     proxy_signal_test.go:59: Error: No such object: repro-28872
22:56:34         
22:56:34     proxy_signal_test.go:60: 
22:56:34         
22:56:34     proxy_signal_test.go:57: exit status 1
22:56:34     proxy_signal_test.go:59: Error: No such object: repro-28872
22:56:34         
22:56:34     proxy_signal_test.go:60: 

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

This should be fixed by #2016

@thaJeztah thaJeztah closed this Sep 2, 2019
@thaJeztah thaJeztah deleted the increase_timeout branch September 2, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants