Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.03 backport] backport bash completion scripts #1876

Merged
merged 5 commits into from
May 13, 2019

Conversation

thaJeztah
Copy link
Member

backports of:

albers and others added 5 commits May 13, 2019 08:45
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit bfa43d2)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 1648d6c)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Trapier Marshall <trapier.marshall@docker.com>
(cherry picked from commit 50a45ba)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit b55992a)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit c1639e1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @albers @silvin-lubecki @tiborvass PTAL

@codecov-io
Copy link

Codecov Report

Merging #1876 into 19.03 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            19.03    #1876   +/-   ##
=======================================
  Coverage   56.75%   56.75%           
=======================================
  Files         309      309           
  Lines       21658    21658           
=======================================
  Hits        12292    12292           
  Misses       8469     8469           
  Partials      897      897

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, LGTM. Thanks for backporting!

@thaJeztah thaJeztah merged commit ac45214 into docker:19.03 May 13, 2019
@thaJeztah thaJeztah deleted the 19.03_backport_completion_scripts branch May 13, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants