Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systctl support for services #1754

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

thaJeztah
Copy link
Member

cli changes for moby/moby#37701

@thaJeztah
Copy link
Member Author

ping @dperny @silvin-lubecki @vdemeester ptal

@thaJeztah thaJeztah added this to the 18.09.4 milestone Mar 19, 2019
@thaJeztah thaJeztah force-pushed the add_sysctls_for_services branch 2 times, most recently from 6327aa3 to bb72d64 Compare March 19, 2019 01:46
@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #1754 into master will increase coverage by 0.05%.
The diff coverage is 92.3%.

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
+ Coverage   56.27%   56.32%   +0.05%     
==========================================
  Files         307      307              
  Lines       21151    21163      +12     
==========================================
+ Hits        11902    11920      +18     
+ Misses       8382     8378       -4     
+ Partials      867      865       -2

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completion LGTM. Flag annotation looks odd.

cli/command/service/create.go Show resolved Hide resolved
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@thaJeztah thaJeztah merged commit 9a39a10 into docker:master Mar 19, 2019
@thaJeztah thaJeztah deleted the add_sysctls_for_services branch March 19, 2019 23:17
@andrewhsu andrewhsu modified the milestones: 18.09.4, 19.03.0 Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants