Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat the output of CLI plugins in docker system info #1689

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

ijc
Copy link
Contributor

@ijc ijc commented Feb 25, 2019

This matches the docker --help output after 9201360.

Signed-off-by: Ian Campbell ijc@docker.com

This covers one of the outstanding items in #1661.

@codecov-io
Copy link

Codecov Report

Merging #1689 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1689      +/-   ##
==========================================
+ Coverage   56.12%   56.12%   +<.01%     
==========================================
  Files         306      306              
  Lines       21025    21028       +3     
==========================================
+ Hits        11800    11803       +3     
  Misses       8371     8371              
  Partials      854      854

This matches the `docker --help` output after 9201360.

Added a unit test case for unversioned.

Signed-off-by: Ian Campbell <ijc@docker.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

with this change;

Client:
 Debug Mode: false
 Plugins:
  compose: Define and run multi-container applications (Docker, Inc.)
  helloworld: A basic Hello World plugin for tests (Docker Inc., testing)

Server:
 Containers: 14
  Running: 8
  Paused: 0
  Stopped: 6

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 9b837be into docker:master Feb 26, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Feb 26, 2019
@ijc ijc deleted the plugins-docker-system-info-format branch February 26, 2019 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants