Compose: Improve error messages when resource create/update fails #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
improve-compose-secrets-errors
branch
from
7c6add8 to
729d07a
Compare
Signed-off-by: Daniel Nephin <dnephin@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
- Coverage 44.96% 44.91% -0.05%
==========================================
Files 169 169
Lines 11381 11367 -14
==========================================
- Hits 5117 5106 -11
+ Misses 5971 5968 -3
Partials 293 293 |
Signed-off-by: Daniel Nephin <dnephin@docker.com>
|
Added another commit which uses a map instead of a switch/case for the compose loader transform |
|
The changes to error messages LGTM. Are the rest of the changes unrelated cleanups? |
|
Yes |
|
LGTM |
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Jun 30, 2020
full diff: mitchellh/mapstructure@v1.0.0...v1.3.2 v1.3.2 - Decode into interface type with a struct value is supported [dockerGH-187] v1.3.1 - Squash should only squash embedded structs. [dockerGH-194] v1.3.0 - Added `",omitempty"` support. This will ignore zero values in the source structure when encoding. [dockerGH-145] v1.2.3 - Fix duplicate entries in Keys list with pointer values. [dockerGH-185] v1.2.2 - Do not add unsettable (unexported) values to the unused metadata key or "remain" value. [dockerGH-150] v1.2.1 - Go modules checksum mismatch fix v1.2.0 - Added support to capture unused values in a field using the `",remain"` value in the mapstructure tag. There is an example to showcase usage. - Added `DecoderConfig` option to always squash embedded structs - `json.Number` can decode into `uint` types - Empty slices are preserved and not replaced with nil slices - Fix panic that can occur in when decoding a map into a nil slice of structs - Improved package documentation for godoc v1.1.2 - Fix error when decode hook decodes interface implementation into interface type. [dockerGH-140] v1.1.1 - Fix panic that can happen in `decodePtr` v1.1.0 - Added `StringToIPHookFunc` to convert `string` to `net.IP` and `net.IPNet` [dockerGH-133] - Support struct to struct decoding [dockerGH-137] - If source map value is nil, then destination map value is nil (instead of empty) - If source slice value is nil, then destination slice value is nil (instead of empty) - If source pointer is nil, then destination pointer is set to nil (instead of allocated zero value of type) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Jun 30, 2020
full diff: mitchellh/mapstructure@v1.0.0...v1.3.2 v1.3.2 - Decode into interface type with a struct value is supported dockerGH-187 v1.3.1 - Squash should only squash embedded structs. dockerGH-194 v1.3.0 - Added `",omitempty"` support. This will ignore zero values in the source structure when encoding. dockerGH-145 v1.2.3 - Fix duplicate entries in Keys list with pointer values. dockerGH-185 v1.2.2 - Do not add unsettable (unexported) values to the unused metadata key or "remain" value. dockerGH-150 v1.2.1 - Go modules checksum mismatch fix v1.2.0 - Added support to capture unused values in a field using the `",remain"` value in the mapstructure tag. There is an example to showcase usage. - Added `DecoderConfig` option to always squash embedded structs - `json.Number` can decode into `uint` types - Empty slices are preserved and not replaced with nil slices - Fix panic that can occur in when decoding a map into a nil slice of structs - Improved package documentation for godoc v1.1.2 - Fix error when decode hook decodes interface implementation into interface type. dockerGH-140 v1.1.1 - Fix panic that can happen in `decodePtr` v1.1.0 - Added `StringToIPHookFunc` to convert `string` to `net.IP` and `net.IPNet` dockerGH-133 - Support struct to struct decoding dockerGH-137 - If source map value is nil, then destination map value is nil (instead of empty) - If source slice value is nil, then destination slice value is nil (instead of empty) - If source pointer is nil, then destination pointer is set to nil (instead of allocated zero value of type) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously secret update errors looked like this:
which do not provide enough details for a user to understand what failed.
Also removes some unnecessary conditions in
deployServices()