-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow npipe volume type on stack file #1195
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -271,7 +271,7 @@ metadata](https://docs.docker.com/engine/userguide/labels-custom-metadata/). | |
Docker supports three different kinds of mounts, which allow containers to read | ||
from or write to files or directories, either on the host operating system, or | ||
on memory filesystems. These types are _data volumes_ (often referred to simply | ||
as volumes), _bind mounts_, and _tmpfs_. | ||
as volumes), _bind mounts_, _tmpfs_, and _named pipes_. | ||
|
||
A **bind mount** makes a file or directory on the host available to the | ||
container it is mounted within. A bind mount may be either read-only or | ||
|
@@ -291,6 +291,8 @@ You can back up or restore volumes using Docker commands. | |
|
||
A **tmpfs** mounts a tmpfs inside a container for volatile data. | ||
|
||
A **npipe** mounts a named pipe from the host into the container. | ||
|
||
Consider a situation where your image starts a lightweight web server. You could | ||
use that image as a base image, copy in your website's HTML files, and package | ||
that into another image. Each time your website changed, you'd need to update | ||
|
@@ -312,21 +314,22 @@ volumes in a service: | |
<th>Description</th> | ||
</tr> | ||
<tr> | ||
<td><b>types</b></td> | ||
<td><b>type</b></td> | ||
<td></td> | ||
<td> | ||
<p>The type of mount, can be either <tt>volume</tt>, <tt>bind</tt>, or <tt>tmpfs</tt>. Defaults to <tt>volume</tt> if no type is specified. | ||
<p>The type of mount, can be either <tt>volume</tt>, <tt>bind</tt>, <tt>tmpfs</tt>, or <tt>npipe</tt>. Defaults to <tt>volume</tt> if no type is specified. | ||
<ul> | ||
<li><tt>volume</tt>: mounts a <a href="https://docs.docker.com/engine/reference/commandline/volume_create/">managed volume</a> | ||
into the container.</li> <li><tt>bind</tt>: | ||
bind-mounts a directory or file from the host into the container.</li> | ||
<li><tt>tmpfs</tt>: mount a tmpfs in the container</li> | ||
<li><tt>npipe</tt>: mounts named pipe from the host into the container (Windows containers only).</li> | ||
</ul></p> | ||
</td> | ||
</tr> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you also update the It currently says;
Which should now be;
(Noticed there's a stray |
||
<tr> | ||
<td><b>src</b> or <b>source</b></td> | ||
<td>for <tt>type=bind</tt> only></td> | ||
<td>for <tt>type=bind</tt> and <tt>type=npipe</tt></td> | ||
<td> | ||
<ul> | ||
<li> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice catch