Skip to content

Commit

Permalink
Merge pull request #5423 from thaJeztah/27.x_backport_info_no_expecte…
Browse files Browse the repository at this point in the history
…d_version

[27.x backport] info: stop printing "Expected" commits
  • Loading branch information
thaJeztah committed Sep 10, 2024
2 parents 65decb5 + 4be6b1f commit 05fb576
Showing 1 changed file with 3 additions and 15 deletions.
18 changes: 3 additions & 15 deletions cli/command/system/info.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,21 +273,9 @@ func prettyPrintServerInfo(streams command.Streams, info *dockerInfo) []error {

if info.OSType == "linux" {
fprintln(output, " Init Binary:", info.InitBinary)

for _, ci := range []struct {
Name string
Commit system.Commit
}{
{"containerd", info.ContainerdCommit},
{"runc", info.RuncCommit},
{"init", info.InitCommit},
} {
fprintf(output, " %s version: %s", ci.Name, ci.Commit.ID)
if ci.Commit.ID != ci.Commit.Expected {
fprintf(output, " (expected: %s)", ci.Commit.Expected)
}
fprintln(output)
}
fprintln(output, " containerd version:", info.ContainerdCommit.ID)
fprintln(output, " runc version:", info.RuncCommit.ID)
fprintln(output, " init version:", info.InitCommit.ID)
if len(info.SecurityOptions) != 0 {
if kvs, err := system.DecodeSecurityOptions(info.SecurityOptions); err != nil {
errs = append(errs, err)
Expand Down

0 comments on commit 05fb576

Please sign in to comment.