bake: add basename, dirname and sanitize functions #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions help with dealing with path inputs and using parts of them to configure targets. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
bake-path-stdlib-functions
branch
from
4f2bd74
to
a4adae3
Compare
dvdksn
reviewed
Aug 13, 2024
There was a problem hiding this comment.
(follow-up) do we want to create a reference doc for the stdlib functions we ship? Right now we only refer to go-cty which is incorrect https://docs.docker.com/build/bake/funcs/#standard-library
This would be nice indeed. Ideally, we could maybe generate that list as we do with the flags. |
crazy-max
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions help with dealing with path inputs and using parts of them to configure targets.
For example, this improves cases like https://github.com/moby/buildkit/pull/5248/files#diff-870f6fe23fc034f008f5203ee1e628d7bfa65a49095d5a4688db498328449ed2R238 where current best approach is to take hash and lose readability of the variable.