Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: return error if all nodes fail to boot #1869

Merged
merged 1 commit into from
Oct 25, 2023
Merged

builder: return error if all nodes fail to boot #1869

merged 1 commit into from
Oct 25, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jun 7, 2023 •
edited
Loading

fixes docker/setup-buildx-action#228 (comment)

Before:

#1 [internal] booting buildkit
#1 pulling image moby/buildkit:buildx-stable-1
#1 pulling image moby/buildkit:buildx-stable-1 1.6s done
#1 creating container buildx_buildkit_builder-cc8757dc-a94d-4ea0-ac4a-592280318e710 done
#1 ERROR: Error response from daemon: Windows does not support privileged mode
------
 > [internal] booting buildkit:
------
Name:          builder-cc8757dc-a94d-4ea0-ac4a-592280318e71
Driver:        docker-container
Last Activity: 2023-10-23 12:13:15 +0000 UTC

Nodes:
Name:      builder-cc8757dc-a94d-4ea0-ac4a-592280318e710
Endpoint:  npipe:////./pipe/docker_engine
Status:    inactive
Flags:     --allow-insecure-entitlement security.insecure --allow-insecure-entitlement network.host
Platforms:

Now:

#1 [internal] booting buildkit
pedantic_hopper
#1 pulling image moby/buildkit:buildx-stable-1
#1 pulling image moby/buildkit:buildx-stable-1 1.4s done
#1 creating container buildx_buildkit_pedantic_hopper0 0.0s done
#1 ERROR: Error response from daemon: Windows does not support privileged mode
------
 > [internal] booting buildkit:
------
ERROR: Error response from daemon: Windows does not support privileged mode

@crazy-max crazy-max marked this pull request as ready for review October 23, 2023 13:11
@crazy-max crazy-max added this to the v0.12.0 milestone Oct 23, 2023
jsternberg
jsternberg requested changes Oct 23, 2023
View reviewed changes
builder/builder.go Outdated Show resolved Hide resolved
@crazy-max
builder: return error if all nodes fail to boot
612dfdd 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from jsternberg October 24, 2023 08:59
@crazy-max crazy-max merged commit e437f7b into docker:master Oct 25, 2023
59 checks passed
@crazy-max crazy-max deleted the fix-boot branch October 25, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsternberg jsternberg jsternberg approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

buildx failed with: ERROR: Error response from daemon: Windows does not support privileged mode
2 participants
@crazy-max @jsternberg