Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: update min go version #88

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Dec 16, 2023

Don't think we require 1.21.3 as min go version, 1.21.0 should be enough. Also tried to set 1.21 but it seems tidy complains and expects a patch release 1.21.0: https://github.com/docker/buildkit-syft-scanner/actions/runs/7232529430/job/19706797619#step:4:447

Not sure why in other projects like https://github.com/docker/buildx/blob/8484fcdd5715c0683e8605e05cdffc0bfa8fde94/go.mod#L3 it doesn't complain though 🤔

Maybe something is cached on golang proxy?

Also add commit to align go version in vendor dockerfile.

@crazy-max crazy-max changed the title gomod: set major.minor for min go version gomod: update min go version Dec 16, 2023
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review December 17, 2023 09:07
@crazy-max
Copy link
Member Author

Maybe something is cached on golang proxy?

Ok found why: https://go.dev/doc/toolchain

"The go get and go mod tidy commands maintain the go line to be greater than or equal to the go line of any required dependency module."

So in this case https://github.com/anchore/syft/blob/f4dd36ca9d8ac8f31bf3a9223f24b4647098c437/go.mod#L3 😢

@jedevc
Copy link
Collaborator

jedevc commented Dec 18, 2023

@crazy-max looks like this comes from anchore/syft#2108?

@crazy-max
Copy link
Member Author

@crazy-max looks like this comes from anchore/syft#2108?

Yes indeed. I tried to set back 1.21 in syft but it also enforces 1.21.0 because one of underlying modules is 1.21.0

@crazy-max crazy-max merged commit 0d6596e into docker:master Dec 18, 2023
9 checks passed
@crazy-max crazy-max deleted the fix-gomod branch December 18, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants