Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: add a vendor directory #61

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

jedevc
Copy link
Collaborator

@jedevc jedevc commented Jun 16, 2023

This does a couple of things:

  • Keeps us inline with other "build" repos - buildx, buildkit, etc.
  • Makes dependabot for new versions of syft a lot easier to review, since we can easily analyze exactly what code that we are using is changing.

@jedevc jedevc requested a review from cdupuis as a code owner June 16, 2023 09:54
@jedevc jedevc force-pushed the add-vendor-directory branch from 39c9476 to 5cbf40b Compare June 16, 2023 09:58
crazy-max
crazy-max previously approved these changes Jun 16, 2023
@crazy-max crazy-max dismissed their stale review June 16, 2023 11:35

A bit too fast for this review

@crazy-max
Copy link
Member

crazy-max commented Jun 16, 2023

RUN --mount=type=bind,source=go.mod,target=go.mod \
--mount=type=bind,source=go.sum,target=go.sum \
--mount=type=cache,target=/go/pkg/mod \
go mod download -x
needs to be removed

--mount=type=cache,target=/go/pkg/mod \
as well

Also needs https://github.com/docker/buildx/blob/daba16f4be78f4bb6bb6ac73ac5c5615023a2bd7/Dockerfile#L20

jedevc added 2 commits June 20, 2023 11:47
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc force-pushed the add-vendor-directory branch from 0f751ca to 4428ecc Compare June 20, 2023 10:47
@jedevc jedevc requested a review from crazy-max June 20, 2023 10:47
@jedevc
Copy link
Collaborator Author

jedevc commented Jun 20, 2023

Woop, thanks @crazy-max ❤️

@jedevc jedevc merged commit 95ed35b into docker:master Jun 20, 2023
@jedevc jedevc deleted the add-vendor-directory branch June 20, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants