Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: update syft to v0.66 #19

Closed
wants to merge 1 commit into from
Closed

vendor: update syft to v0.66 #19

wants to merge 1 commit into from

Conversation

jedevc
Copy link
Collaborator

@jedevc jedevc commented Jan 17, 2023 •
edited
Loading

@jedevc jedevc requested a review from crazy-max January 17, 2023 10:26
@jedevc
Copy link
Collaborator Author

jedevc commented Jan 17, 2023 •
edited
Loading

Syft 0.66.0 is broken, so probably should use the next patch release, see anchore/syft#1453.

The following Dockerfile:

#syntax=docker/dockerfile:1
FROM ubuntu:20.04

RUN apt-get update && apt-get install -y python3 python3-pip

Building with: docker buildx build . --sbom=generator=localhost:5000/buildkit-syft-scanner:dev:

#0 2.907 panic: interface conversion: interface {} is *pe.OptionalHeader32, not *pe.OptionalHeader64
#0 2.907 
#0 2.907 goroutine 7 [running]:
#0 2.907 github.com/anchore/syft/syft/pkg/cataloger/java.newPE({0xc0007a5fc0, 0x34}, {0x7f23857ab6d0, 0xc000bcf998?})
#0 2.907 	github.com/anchore/syft@v0.66.0/syft/pkg/cataloger/java/graalvm_native_image_cataloger.go:234 +0x4e9
#0 2.907 github.com/anchore/syft/syft/pkg/cataloger/java.fetchPkgs({0x7f23857ab698?, 0xc000bcf998?}, {0xc0007a5fc0, 0x34})
#0 2.907 	github.com/anchore/syft@v0.66.0/syft/pkg/cataloger/java/graalvm_native_image_cataloger.go:510 +0x218
#0 2.907 github.com/anchore/syft/syft/pkg/cataloger/java.(*NativeImageCataloger).Catalog(0xc00037c660?, {0x12bc4f8, 0xc0001a04d0})
#0 2.907 	github.com/anchore/syft@v0.66.0/syft/pkg/cataloger/java/graalvm_native_image_cataloger.go:544 +0x4e5
#0 2.907 github.com/anchore/syft/syft/pkg/cataloger.runCataloger({0x12b4328, 0x1b02f68}, {0x12bc4f8?, 0xc0001a04d0})
#0 2.907 	github.com/anchore/syft@v0.66.0/syft/pkg/cataloger/catalog.go:57 +0x188
#0 2.907 github.com/anchore/syft/syft/pkg/cataloger.Catalog.func1()
#0 2.907 	github.com/anchore/syft@v0.66.0/syft/pkg/cataloger/catalog.go:127 +0x105
#0 2.907 created by github.com/anchore/syft/syft/pkg/cataloger.Catalog
#0 2.907 	github.com/anchore/syft@v0.66.0/syft/pkg/cataloger/catalog.go:122 +0x2b0
------
ERROR: failed to solve: process "/bin/syft-scanner" did not complete successfully: exit code: 2

@jedevc
vendor: update syft to v0.66.1
a5dbfac 
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc changed the title vendor: update syft to v0.66.0 vendor: update syft to v0.66 Jan 17, 2023
@jedevc jedevc marked this pull request as ready for review January 17, 2023 10:54
@jedevc
Copy link
Collaborator Author

jedevc commented Jan 17, 2023

Still a bit worried by anchore/syft#1462, probably worth waiting for a fix to land.

@jedevc jedevc added status/do-not-merge Explicitly marked as incomplete/broken area/syft Related to upstream syft changes labels Jan 17, 2023
@crazy-max
Copy link
Member

crazy-max commented Jan 17, 2023 •
edited
Loading

We should have a workflow here to ensure the image still works before merging. Also related to #20.

@jedevc jedevc mentioned this pull request Jan 23, 2023
Merged
@jedevc jedevc closed this Jan 23, 2023
@jedevc jedevc deleted the syft-0.66.0 branch January 23, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

Assignees
No one assigned
Labels
area/syft Related to upstream syft changes status/do-not-merge Explicitly marked as incomplete/broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedevc @crazy-max