Execute syft scan in chroot environment #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When scanning a directory, the syft scanner resolves symlinks inside the target directory in the context of the host filesystem. However, for our purposes, the target filesystem is entirely self-contained. In lieu of syft changes, we can temporarily hack around this limitation by executing the scanner in a chroot-ed environment. Signed-off-by: Justin Chadwell <me@jedevc.com>
tonistiigi
approved these changes
Jan 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scanning a directory, the syft scanner resolves symlinks inside the target directory in the context of the host filesystem. However, for our purposes, the target filesystem is entirely self-contained. In lieu of syft changes, we can temporarily hack around this limitation by executing the scanner in a chroot-ed environment.
See anchore/syft#1359 for more context.
With this change, we see fewer warning messages of the form (though we may still see some due to broken symlinks):