ci: opt-in sbom and provenance #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
jedevc
reviewed
Dec 16, 2022
Dockerfile
Outdated
| @@ -40,6 +40,8 @@ RUN --mount=target=. <<EOT | |||
| EOT | |||
|
|
|||
| FROM base as build | |||
| # enable scanning for this stage | |||
| ARG BUILDKIT_SBOM_SCAN_STAGE=true | |||
There was a problem hiding this comment.
We don't need scanning at this step - the golang dependencies are automatically loaded from the go binary /bin/syft-scanner. This just also pulls in all the stuff from the build stages.
This doesn't work in buildkit, because syft doesn't open up tarballs it seems, I'll see if I can follow that up.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
jedevc
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.