Port the scanner to Go #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
|
Have purposely left the |
crazy-max
reviewed
Nov 21, 2022
crazy-max
reviewed
Nov 21, 2022
internal/target.go
Outdated
| const defaultSyftVersion = "[not provided]" | ||
|
|
||
| var ( | ||
| SyftVersion = defaultSyftVersion |
There was a problem hiding this comment.
Can be set directly:
Suggested change
| SyftVersion = defaultSyftVersion | |
| SyftVersion = "v0.0.0+unknown" |
There was a problem hiding this comment.
LGTM, but would like to keep [not provided], inline with how syft itself shows an unknown version.
There was a problem hiding this comment.
We could propose a change to how syft does this?
There was a problem hiding this comment.
LGTM, but would like to keep
[not provided], inline with how syft itself shows an unknown version.
Ah ok didn't know they have this pattern, let's keep it like this in the meantime then
Signed-off-by: Justin Chadwell <me@jedevc.com>
crazy-max
approved these changes
Nov 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.