-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for git-lfs #312
Comments
As a mitigation, this action uses whatever is checked out with |
@roim Do you have a link to your repo for repro please? You can use the Path context (with checkout action) in the meantime. |
@crazy-max it's a private one but I can set up a public repro tomorrow. And thanks for the tip on path context, I'll test it but that should work as a cleaner mitigation. |
Repro here: https://github.com/roim/docker-action-lfs Check how a That said, passing a custom context, and setting up an lfs checkout beforehand, will work. I'm sure it's not practical to support every git extension, but lfs is fairly standard and supported by the github checkout action. Maybe an example or comment in the readme would be enough? |
Ok looks like it's not implemented on buildkit. Would need a specific option to enable this feature. The command would look like |
Are there any updates on this? :) |
Any updates on this? |
For anyone else with this issue, see this repo for a workaround: |
Thanks, made my day. |
According to [0] if we pass in a custom context with git lfs enabled then the build should work. [0] docker/build-push-action#312
According to [0] if we pass in a custom context with git lfs enabled then the build should work. [0] docker/build-push-action#312
This commit configures docker/build-push-action to use path context in order to get git-lfs working. See docker/build-push-action#312 for context.
Behaviour
Steps to reproduce this issue
git lfs track "*.png"
).COPY
those files in your Dockerfile.Expected behaviour
Actual behaviour
Configuration
Happens on the current README config.
More
This is extra confusing because any
actions/checkout
runs withlfs: true
are ignored since this action is doing its own checkout. E.g. see this on stack overflow--there are several other reports scattered around.Separately, DockerHub also lacks git-lfs support, that is mentioned in its docs and also in this Issue: Add support for Git LFS. hub-feedback#500
The text was updated successfully, but these errors were encountered: