This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
WIP: refactor as a CLI plugin #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "cli-plugin" git@github.com:ijc/docker-app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354474752
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
9 tasks
ijc
force-pushed
the
cli-plugin
branch
3 times, most recently
from
8e34d48 to
3d3f959
Compare
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 62.65% 62.54% -0.12%
==========================================
Files 49 49
Lines 2362 2339 -23
==========================================
- Hits 1480 1463 -17
+ Misses 679 676 -3
+ Partials 203 200 -3
Continue to review full report at Codecov.
|
|
Self Reminder: There's a bunch of docs updates required here too. |
added 2 commits
January 29, 2019 15:35
Needed some dependency bumps for newer deps (docker/docker and grpc) plus tweaks to the app due to api changes. Signed-off-by: Ian Campbell <ijc@docker.com>
docker/cli#1564 Since this pushes the actual command down to `docker-app app`, adjust the e2e tests with: $ sed -Eie 's/icmd\.RunCommand\(dockerApp,/icmd.RunCommand(dockerApp, "app",/g' e2e/*.go $ sed -Eie 's/exec.Command\(dockerApp,/exec.Command(dockerApp, "app",/g' e2e/*.go $ sed -Eie 's/\[\]string\{dockerApp,/\[\]string\{dockerApp, "app",/g' e2e/*.go (which might be precisely equivalent to `sed -Eie 's/dockerApp,/dockerApp, "app",/g' e2e/*.go`) Finally, the idiom in docker/cli (for better or worse) is to include an "Error: " prefix in the error string itself, rather than injecting it when printing. Since CLI plugins follow the behaviour of the CLI here it is necessary to prepend "Error: " to some messages. I've only done exactly those necessary to pass the e2e tests, a fuller audit is very likely required. Signed-off-by: Ian Campbell <ijc@docker.com>
|
Closing in favour of #469 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
First pass refactoring as a plugin using the framework from docker/cli#1564.
I intend to track that PR using app as a test case for the framework. Shouldn't be merged until the plugins stuff is available!
- How to verify it
With a
dockerCLI binary build from docker/cli#1564 place thedocker-appbuilt from this PR in the plugin search path (or setDOCKER_CLI_PLUGIN_EXTRA_DIRSto point to a directory containingdocker-app). Thendocker app «foof»should work asdocker-app «foof»did previously.