This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Use docker/cli template.ExtractVariables instead of own impl. #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
requested review from
mat007,
chris-crone,
mnottale and
silvin-lubecki
vdemeester
force-pushed
the
clean-extract-variables
branch
from
78c3826 to
e31c7ab
Compare
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
- Coverage 56.46% 56.13% -0.33%
==========================================
Files 50 50
Lines 2600 2551 -49
==========================================
- Hits 1468 1432 -36
+ Misses 923 913 -10
+ Partials 209 206 -3
Continue to review full report at Codecov.
|
vdemeester
force-pushed
the
clean-extract-variables
branch
from
e31c7ab to
36dd8b0
Compare
chris-crone
approved these changes
Jul 31, 2018
mnottale
approved these changes
Aug 1, 2018
silvin-lubecki
suggested changes
Aug 1, 2018
|
Please rebase 🐱 |
|
LGTM otherwise 😅 |
vdemeester
force-pushed
the
clean-extract-variables
branch
2 times, most recently
from
4d91afe to
1eed03e
Compare
|
@silvin-lubecki updated with |
silvin-lubecki
approved these changes
Aug 1, 2018
vdemeester
force-pushed
the
clean-extract-variables
branch
from
1eed03e to
39222dd
Compare
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
clean-extract-variables
branch
from
39222dd to
e73acc6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on docker/cli#1249
Signed-off-by: Vincent Demeester vincent@sbr.pm