-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add ubuntu arm runners #558
Conversation
crazy-max
commented
Jan 17, 2025
•
edited
Loading
edited
- https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
- https://github.com/actions/partner-runner-images
|
2d48a9d
to
72b9558
Compare
Some tests fail on arm64 runner: https://github.com/docker/actions-toolkit/actions/runs/12843876100/job/35816305436?pr=558#step:2:2318
Might need changes in |
a46b516
to
37e1b57
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
37e1b57
to
6f40a34
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
6f40a34
to
1b6fc22
Compare
@@ -60,6 +60,7 @@ describe('download', () => { | |||
])( | |||
'acquires %p of docker (%s)', async (source, platformOS) => { | |||
jest.spyOn(osm, 'platform').mockImplementation(() => platformOS as NodeJS.Platform); | |||
jest.spyOn(osm, 'arch').mockImplementation(() => 'x64'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might need changes in
hubRepository.ts
or we could just use undock directly.
Ok this was just a matter of updating tests to enforce arch platform to x64.