Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add ubuntu arm runners #558

Merged
merged 2 commits into from
Jan 20, 2025
Merged

ci: add ubuntu arm runners #558

merged 2 commits into from
Jan 20, 2025

Conversation

@crazy-max
Copy link
Member Author

@crazy-max crazy-max changed the title ci(virtual-env): add ubuntu arm runners ci: add ubuntu arm runners Jan 18, 2025
@crazy-max
Copy link
Member Author

crazy-max commented Jan 19, 2025

Some tests fail on arm64 runner: https://github.com/docker/actions-toolkit/actions/runs/12843876100/job/35816305436?pr=558#step:2:2318

#22 54.83 FAIL __tests__/docker/install.test.ts (40.814 s)
#22 54.83   download
#22 54.83     ✓ acquires {"channel": "stable", "type": "archive", "version": "v19.03.14"} of docker (linux) (4686 ms)
#22 54.83     ✓ acquires {"channel": "stable", "type": "archive", "version": "v20.10.22"} of docker (linux) (7008 ms)
#22 54.83     ✓ acquires {"channel": "stable", "type": "archive", "version": "v20.10.22"} of docker (darwin) (9634 ms)
#22 54.83     ✕ acquires {"channel": "stable", "type": "archive", "version": "v20.10.22"} of docker (win32) (90 ms)
#22 54.83     ✓ acquires {"tag": "master", "type": "image"} of docker (linux) (12661 ms)
#22 54.83     ✕ acquires {"tag": "master", "type": "image"} of docker (win32) (707 ms)
#22 54.83     ✓ acquires {"tag": "27.3.1", "type": "image"} of docker (linux) (4185 ms)
#22 54.83     ✕ acquires {"tag": "27.3.1", "type": "image"} of docker (win32) (631 ms)
#22 54.83   getRelease
#22 54.83     ✓ returns latest docker GitHub release (15 ms)
#22 54.83     ✓ returns v23.0.0 buildx GitHub release (10 ms)
#22 54.83     ✓ unknown release (50 ms)
#22 54.83   limaImage
#22 54.83     ✓ returns custom images (2 ms)
#22 54.83 
#22 54.83   ● download › acquires {"channel": "stable", "type": "archive", "version": "v20.10.22"} of docker (win32)
#22 54.83 
#22 54.83     Unexpected HTTP response: 404
#22 54.83 
#22 54.83       at node_modules/@actions/tool-cache/src/tool-cache.ts:106:17
#22 54.83       at fulfilled (node_modules/@actions/tool-cache/lib/tool-cache.js:28:58)
#22 54.83 
#22 54.83   ● download › acquires {"tag": "master", "type": "image"} of docker (win32)
#22 54.83 
#22 54.83     Cannot find manifest for windows/arm64/
#22 54.83 
#22 54.83       167 |     if (!manifest) {
#22 54.83       168 |       core.error(`Cannot find manifest for ${pos}/${arch}/${variant}`);
#22 54.83     > 169 |       throw new Error(`Cannot find manifest for ${pos}/${arch}/${variant}`);
#22 54.83           |             ^
#22 54.83       170 |     }
#22 54.83       171 |
#22 54.83       172 |     return manifest.digest;
#22 54.83 
#22 54.83       at Function.getPlatformManifestDigest (src/hubRepository.ts:169:13)
#22 54.83       at HubRepository.getPlatformManifestDigest (src/hubRepository.ts:49:34)
#22 54.83       at fulfilled (src/hubRepository.ts:4058:24)
#22 54.83 
#22 54.83   ● download › acquires {"tag": "27.3.1", "type": "image"} of docker (win32)
#22 54.83 
#22 54.83     Cannot find manifest for windows/arm64/
#22 54.83 
#22 54.83       167 |     if (!manifest) {
#22 54.83       168 |       core.error(`Cannot find manifest for ${pos}/${arch}/${variant}`);
#22 54.83     > 169 |       throw new Error(`Cannot find manifest for ${pos}/${arch}/${variant}`);
#22 54.83           |             ^
#22 54.83       170 |     }
#22 54.83       171 |
#22 54.83       172 |     return manifest.digest;
#22 54.83 
#22 54.83       at Function.getPlatformManifestDigest (src/hubRepository.ts:169:13)
#22 54.83       at HubRepository.getPlatformManifestDigest (src/hubRepository.ts:49:34)
#22 54.83       at fulfilled (src/hubRepository.ts:4058:24)

Might need changes in hubRepository.ts or we could just use undock directly.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@@ -60,6 +60,7 @@ describe('download', () => {
])(
'acquires %p of docker (%s)', async (source, platformOS) => {
jest.spyOn(osm, 'platform').mockImplementation(() => platformOS as NodeJS.Platform);
jest.spyOn(osm, 'arch').mockImplementation(() => 'x64');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need changes in hubRepository.ts or we could just use undock directly.

Ok this was just a matter of updating tests to enforce arch platform to x64.

@crazy-max crazy-max marked this pull request as ready for review January 20, 2025 09:29
@crazy-max crazy-max merged commit 6b5c60a into docker:main Jan 20, 2025
92 checks passed
@crazy-max crazy-max deleted the ci-virtualenv branch January 20, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant