Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildx: make name opt optional when inspecting builder #319

Merged
merged 1 commit into from
Apr 25, 2024
Merged

buildx: make name opt optional when inspecting builder #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/buildx/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export class Builder {
return ok;
}

public async inspect(name: string): Promise<BuilderInfo> {
public async inspect(name?: string): Promise<BuilderInfo> {
// always enable debug for inspect command, so we can display additional
// fields such as features: https://github.com/docker/buildx/pull/1854
const envs = Object.assign({}, process.env, {
Expand All @@ -64,7 +64,12 @@ export class Builder {
[key: string]: string;
};

const cmd = await this.buildx.getCommand(['inspect', name]);
const args = ['inspect'];
if (name) {
args.push(name);
}

const cmd = await this.buildx.getCommand(args);
return await Exec.getExecOutput(cmd.command, cmd.args, {
ignoreReturnCode: true,
silent: true,
Expand Down
Loading