Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to php-7.4.0 #910

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Update to php-7.4.0 #910

merged 2 commits into from
Nov 28, 2019

Conversation

nick-zh
Copy link
Contributor

@nick-zh nick-zh commented Nov 28, 2019

No description provided.

@nick-zh
Copy link
Contributor Author

nick-zh commented Nov 28, 2019

@tianon please let me know if this is ok 👍

@tianon
Copy link
Member

tianon commented Nov 28, 2019

At a glance this looks good, I think we need to also update generate-stackbrew-library.sh (we're all on PTO now -- it's not just a holiday but it's one of the Big Four US holidays 😅)

@nick-zh
Copy link
Contributor Author

nick-zh commented Nov 28, 2019

@tianon thanks a lot, i totally missed that and adjusted accordingly. Very sry to have pinged you on a holiday 🙇‍♂️ i was just super excited and wanted to help out. Happy thanksgiving and have a great day! 🦃

@JoelLinn
Copy link

JoelLinn commented Nov 28, 2019 •
edited
Loading

Shouldn’t we squash(fixup) those two commits?

Also, does this affect us?

A number of extensions have been migrated to exclusively use pkg-config for the
detection of library dependencies. Generally, this means that instead of using
--with-foo-dir=DIR or similar only --with-foo is used. Custom library paths can
be specified either by adding additional directories to PKG_CONFIG_PATH or by
explicitly specifying compilation options through FOO_CFLAGS and FOO_LIBS.

@nick-zh
Copy link
Contributor Author

nick-zh commented Nov 28, 2019

I guess they squash merge the branch anyway.
I am not sure about the pkg-config thing, but i am sure after thanksgiving we'll get some feedback on that

@kasp3r kasp3r mentioned this pull request Nov 28, 2019
Closed
@thaJeztah
Copy link
Contributor

I guess they squash merge the branch anyway.

Not sure if they do, but if they do; I noticed you GPG signed your commits; that will be lost when the GitHub squash and merge feature is used.

@tianon
Copy link
Member

tianon commented Nov 28, 2019

Very sry to have pinged you on a holiday i was just super excited and wanted to help out. Happy thanksgiving and have a great day!

Don't worry about it in the slightest -- it's my own fault for checking email! 😄
(It's definitely an odd time for the upstream release, given the potential for downstream delays, but such is life. 😄)

I've got a few minutes this morning to look this over, and it all looks great, thanks! I'm not worried about two commits. 👍

@tianon tianon merged commit 55e0906 into docker-library:master Nov 28, 2019
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 28, 2019
@docker-library-bot
Update php
ac8ad75 
Changes:

- docker-library/php@4aa1f0e: Apply update.sh (www.php.net vs secure.php.net)
- docker-library/php@55e0906: Merge pull request docker-library/php#910 from nick-zh/php-7.4.0
- docker-library/php@76b6033: adjust aliases
- docker-library/php@e186b9b: update to php-7.4.0
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 28, 2019
@docker-library-bot
Update php
31bdee5 
Changes:

- docker-library/php@2bf33a8: Merge pull request docker-library/php#909 from infosiftr/SIGWINCH
- docker-library/php@49d8614: Swap "WINCH" for "SIGWINCH" (which fixes containerd's ability to use this value)
- docker-library/php@4aa1f0e: Apply update.sh (www.php.net vs secure.php.net)
- docker-library/php@55e0906: Merge pull request docker-library/php#910 from nick-zh/php-7.4.0
- docker-library/php@76b6033: adjust aliases
- docker-library/php@e186b9b: update to php-7.4.0
@tianon tianon mentioned this pull request Nov 28, 2019
Merged
@nick-zh
Copy link
Contributor Author

nick-zh commented Nov 28, 2019

@tianon thank you very much for taking the time!

@JoelLinn JoelLinn mentioned this pull request Nov 30, 2019
Closed
This was referenced Dec 3, 2019
Merged
Closed
Closed
@wglambert wglambert mentioned this pull request Jan 20, 2020
Closed
@rizkysyazuli rizkysyazuli mentioned this pull request Feb 24, 2020
Closed
AlpayY added a commit to AlpayY/YouPHPTube that referenced this pull request Sep 1, 2020
@AlpayY
Fixed non-functional Dockerfile for newer (7.4+) php versions
bf82d42 
With update php-7.4 (docker-library/php#910 (comment)) the --with-freetype-dir and --with-jpeg-dir were renamed and mbstring does not need to be installed for the php:7-apache image anymore (https://stackoverflow.com/questions/59251008/docker-laravel-configure-error-package-requirements-oniguruma-were-not-m)
@AlpayY AlpayY mentioned this pull request Sep 1, 2020
Open
AlpayY added a commit to AlpayY/YouPHPTube-Encoder that referenced this pull request Sep 1, 2020
@AlpayY
Fixed non-functional Dockerfile for newer (7.4+) php versions
e3677a6 
With update php-7.4 (docker-library/php#910 (comment)) the --with-freetype-dir and --with-jpeg-dir were renamed and mbstring does not need to be installed for the php:7-apache image anymore (https://stackoverflow.com/questions/59251008/docker-laravel-configure-error-package-requirements-oniguruma-were-not-m)
@AlpayY AlpayY mentioned this pull request Sep 1, 2020
Open
jlyon added a commit to proudcity/wp-proudcity that referenced this pull request Jan 14, 2022
@jlyon
Fix issue building gd docker-library/php#910 (comment)
c7bbd05
@eduard13 eduard13 mentioned this pull request Jan 26, 2022
Merged
@eduard13 eduard13 mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nick-zh @tianon @JoelLinn @thaJeztah